Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable 'Lin.Internal CList int test with Thread' under bytecode #435

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented Jan 23, 2024

OCaml's systhread context switching varies between the native and bytecode modes.
This is challenging to the experimental Thread modes and the package tests of it.
As a result

  • both Lin.Internal ref int/int64 test with Thread have been disabled in bytecode mode
  • the Lin.Internal CList int64 test with Thread has also been disabled in bytecode mode

This left Lin.Internal CList int test with Thread - which is marked as a positive test, but would occasionally find an unexpected counterexample in bytecode mode, causing a false alarm #358 - most recently in both bytecode trunk runs from #434.

This PR thus disables Lin.Internal CList int test with Thread in bytecode mode too.
It should eliminate another cause of false alarms.

Fixes #358

@jmid
Copy link
Collaborator Author

jmid commented Jan 23, 2024

CI summary:

Out of 44 workflows, 1 failed - with a genuine issue 🎉

@jmid jmid merged commit c4cc183 into main Jan 23, 2024
33 of 34 checks passed
@jmid jmid deleted the disable-lin-internal-thread-test branch January 23, 2024 10:32
@jmid
Copy link
Collaborator Author

jmid commented Jan 23, 2024

CI summary for merge to main:

Out of 45 workflows, 2 failed - with genuine issues 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lin.Internal Thread int CList test finds unexpected counterexample under bytecode
1 participant