Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug bytecode #448

Closed
wants to merge 2 commits into from
Closed

Add debug bytecode #448

wants to merge 2 commits into from

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented Mar 27, 2024

@jmid jmid force-pushed the add-debug-bytecode branch from cabab44 to 527b90a Compare August 13, 2024 16:25
@jmid
Copy link
Collaborator Author

jmid commented Aug 13, 2024

Rebased and updated

  • to reflect the macOS ARM64 vs Intel workflow split
  • to add scheduled runs on these new workflows

@jmid jmid force-pushed the add-debug-bytecode branch from 527b90a to b9d64e6 Compare December 20, 2024 16:05
@jmid
Copy link
Collaborator Author

jmid commented Dec 20, 2024

Rebased and updated

  • to reflect the new GitHub actions setup and
  • adding a 5.4.0 workflow too

This is now limited to just Linux bytecode debug. We have seen mostly runtime assertion failures recently, so it should be helpful to catch these under the bytecode interpreter too.

@jmid jmid changed the title [WIP] Add debug bytecode Add debug bytecode Dec 20, 2024
@jmid
Copy link
Collaborator Author

jmid commented Dec 20, 2024

Note to self: Like the native debug workflows, this reuses the cache entries for the non-debug workflows, as both debug and non-debug can be run from the same compiler build. Here are example keys:

  • ocaml-a8e2e13a317facf1cfb9c973dd211ea11b192c1a-linux-x86_64-bytecode-only
  • ocaml-bc5083c1d3b773fc3198355494afd2fb4628ff0e-linux-x86_64-bytecode-only
  • ocaml-f28bfbcb232b017460cb0ba7f9ec8cf1cf773811-linux-x86_64-bytecode-only

@jmid jmid mentioned this pull request Dec 20, 2024
@jmid
Copy link
Collaborator Author

jmid commented Dec 21, 2024

FTR, these are the times for the bytecode debug workflows:

  • Bytecode 5.2 debug / Successful in 180m
  • Bytecode 5.3 debug / Successful in 182m
  • Bytecode trunk debug / Successful in 194m

It seems saying - and excessive - that the fastest ones of those considered take 3h or more.
I'll therefore close this for now.

@jmid jmid closed this Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant