Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using multicore-magic-dscheck for dscheck tests #143

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

lyrm
Copy link
Collaborator

@lyrm lyrm commented Jul 2, 2024

This PR fixes the issue with running DScheck tests on data structures using multicore-magic Transparent_atomic and/or Atomic_array modules. They both need do have their atomic calls shadowed by DScheck's atomics and until now, we were using some working but not generic tricks. Especially, this had some visible consequences on the saturn library itself (with a transparent_atomic module that only had that use).

TODO :

  • Add the proper dependencies to multicore-magic-dscheck and DScheck when their releases.

@lyrm lyrm requested a review from polytypic July 2, 2024 16:13
@polytypic
Copy link
Contributor

This looks nice! 👍

Copy link
Contributor

@polytypic polytypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We obviously need to get rid of the pin-depends, but otherwise this looks very good. So, I'm marking this as approved. 👍

It will probably take some time to go through the opam publish manoeuvers twice (for dscheck and multicore-magic).

@lyrm lyrm merged commit c6729d9 into ocaml-multicore:main Jul 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants