Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time limit for stm tests. #152

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Add time limit for stm tests. #152

merged 2 commits into from
Sep 25, 2024

Conversation

lyrm
Copy link
Collaborator

@lyrm lyrm commented Sep 10, 2024

(Code from picos)

Add a time limit to stm tests.

@polytypic
Copy link
Contributor

Note that some of the STM tests are skipped on some architectures. With the time limits it should be possible to enable those tests on all of the architectures.

@polytypic
Copy link
Contributor

polytypic commented Sep 11, 2024

It seems on ❌ debian-12-5.2_arm32_opam-2.2 (failed: Failed: Build failed) there was a failure:

File "test/michael_scott_queue/dune", line 58, characters 7-30:
58 |  (name stm_michael_scott_queue)
            ^^^^^^^^^^^^^^^^^^^^^^^
(cd _build/default/test/michael_scott_queue && ./stm_michael_scott_queue.exe)

Usually the output looks like that when there is a segmentation fault.

Addition: It might be related to this.

@lyrm
Copy link
Collaborator Author

lyrm commented Sep 23, 2024

Thanks for noticing ! If it is unrelated to the PR itself, should I merge ?

@polytypic
Copy link
Contributor

Thanks for noticing ! If it is unrelated to the PR itself, should I merge ?

Yes, I believe the segfaults are not caused by code in this PR. There are at least a couple of known issues in 5.2 that can cause segfaults. One of them has been fixed and will be in 5.3.

@lyrm lyrm merged commit de75cf4 into ocaml-multicore:main Sep 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants