-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bounded stack #156
Bounded stack #156
Conversation
cbf8675
to
2970bf6
Compare
@Sudha247 : Could you have a look at this PR (at the documentation, or even a quick look at the tests, maybe ?), any feedbacks will be great ! |
1a9fc60
to
5677178
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Some minor comments
2f4b02f
to
8ad3ea6
Compare
@art-w I think this PR is good to. What do you think ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it looks good! Out of curiosity, are the copy_as_padded
on records necessary? (my understanding is that this makes the allocated object fatter, so as to avoid false-sharing contention, but the head
atomic already appears to be protected by make_contended
)
Mmh there is a stack overflow on |
Good question. As nothing else is mutable in the stack type, probably not. |
Additional functions and tests
c3cc626
to
8471c97
Compare
Based on #155. This PR removes the blocking part of the previous PR. The issue with it is that it adds a dependency to
picos
, probably requiring to create aSaturn_picos
package.For Saturn.1.0, we have decided to do only a bounded stack, thus this PR.