Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniformize spcs documentation and functions #165

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

lyrm
Copy link
Collaborator

@lyrm lyrm commented Nov 23, 2024

Changes

  • New functions
    • add drop_exn
    • add of_list
    • add dscheck tests for these new functions
  • Better documentation
    • add examples
    • typos
  • Bench for spsc_queue_unsafe
  • Rename size to length

@lyrm lyrm force-pushed the spsc_documentation branch 2 times, most recently from bee04db to 2b50833 Compare November 26, 2024 18:46
…functions

* Rename Spsc_queue.size to length for uniformization.

* Add examples in documentation

* Add bench for spsc_unsafe.
@lyrm lyrm force-pushed the spsc_documentation branch from 2b50833 to 288bb55 Compare November 26, 2024 18:48
Copy link
Contributor

@art-w art-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/spsc_queue/spsc_queue_intf.mli Outdated Show resolved Hide resolved
src/spsc_queue/spsc_queue_intf.mli Outdated Show resolved Hide resolved
src/spsc_queue/spsc_queue.ml Outdated Show resolved Hide resolved
@lyrm lyrm merged commit fc0e6a2 into ocaml-multicore:main Dec 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants