Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skiplist : doc improvement #172

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Conversation

lyrm
Copy link
Collaborator

@lyrm lyrm commented Nov 28, 2024

Changes

  • Update documentation to match other data structures
  • Add examples

Potential TODO (can be in a future PR)

As the hash table, the functions compare_and_set, compare_and_remove and try_set would be quite useful.

  • find_exn

Note

  • of_list can only be implemented as a List.iter (fun k v -> try_push t k v |> ignore) l so not really interesting
  • try_add_all can't be done atomically

In a future PR

  • try_set
  • compare_and_remove
  • compare_and_set

@lyrm lyrm merged commit 05e0b3a into ocaml-multicore:main Dec 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant