Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Potential TODO (can be in a future PR)
As the hash table, the functions
compare_and_set
,compare_and_remove
andtry_set
would be quite useful.find_exn
Note
of_list
can only be implemented as aList.iter (fun k v -> try_push t k v |> ignore) l
so not really interestingtry_add_all
can't be done atomicallyIn a future PR
try_set
compare_and_remove
compare_and_set