Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Planet: Link to Blog itself #1547

Closed
wants to merge 1 commit into from

Conversation

guptadiksha307
Copy link
Contributor

Issue Description

Fixes #1529

Changes Made

On the right of the planet page (Home -> Community -> OCaml Planet) there is a list of blogs. Clicking on one of them opens the rss rather than the blog itself. I have added a link to the blog itself so that if one of the blogs is clicked, then the main page of the blog opens up.

Please check if the PR fulfills these requirements

  • PR is descriptively titled and links the original issue above
  • Before/after screenshots (if this is a layout change)
  • Details of which platforms the change was tested on (if this is a browser-specific change)
  • Context for what motivated the change (if this is a change to some content)

@pitag-ha
Copy link
Member

Thanks @guptadiksha307 :) including the blog URLs is already one part of the issue. I would suggest that you add the blog URLs to the metadata though instead of replacing the feed URLs by them. Once you've added them, there's the programming bit of the issue left: place a link icon next to each blog, which links to the blog URL you've added. Do you want to work on that?

@guptadiksha307
Copy link
Contributor Author

@pitag-ha yes I want to work on it. Sorry, I Misunderstood the issue earlier.

I would suggest that you add the blog URLs to the metadata though instead of replacing the feed URLs by them.

For this, can you please help in telling me which file I need to modify?

@pitag-ha
Copy link
Member

@guptadiksha307, I've answered to that on the issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On planet: link to blog itself
2 participants