Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dealing with some details #436

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Dealing with some details #436

merged 2 commits into from
Jun 11, 2024

Conversation

yang1666204
Copy link
Collaborator

Summary

  1. Solve some type of problems.
  2. Beautify the UI.
  3. Dealing with some details.
  4. Formatting time.

@yang1666204 yang1666204 added the dashboard The issue or PR is related to oceanbase dashboard label Jun 11, 2024
@yang1666204 yang1666204 self-assigned this Jun 11, 2024
powerfooI
powerfooI requested changes Jun 11, 2024
View reviewed changes
ui/src/type/alert.d.ts Outdated Show resolved Hide resolved
powerfooI
powerfooI approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@powerfooI powerfooI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@powerfooI powerfooI merged commit d897c5e into oceanbase:master Jun 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powerfooI powerfooI powerfooI approved these changes

@HSunboy HSunboy Awaiting requested review from HSunboy

@yezaoshu yezaoshu Awaiting requested review from yezaoshu

Assignees

@yang1666204 yang1666204

Labels
dashboard The issue or PR is related to oceanbase dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yang1666204 @powerfooI