Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

obproxy management #451

Merged
merged 6 commits into from
Jun 17, 2024
Merged

obproxy management #451

merged 6 commits into from
Jun 17, 2024

Conversation

yang1666204
Copy link
Collaborator

Summary

  1. Update API.
  2. Encapsulate a component named TooltipPretty.
  3. Improve the component CustomFormItem.
  4. Support editing obproxy configuration.
  5. Improve the function of creating obproxy.

@yang1666204 yang1666204 added the dashboard The issue or PR is related to oceanbase dashboard label Jun 14, 2024
@yang1666204 yang1666204 requested a review from powerfooI June 14, 2024 09:05
@yang1666204 yang1666204 self-assigned this Jun 14, 2024
powerfooI
powerfooI requested changes Jun 15, 2024
View reviewed changes
ui/src/components/CustomFormItem/index.tsx Show resolved Hide resolved
ui/src/pages/OBProxy/Detail/Overview/ConfigDrawer.tsx Outdated Show resolved Hide resolved
ui/src/pages/OBProxy/Detail/Overview/DetailConfig.tsx Show resolved Hide resolved
ui/src/pages/OBProxy/New/BasicConfig.tsx
message: '请输入k8s资源名称',
},
{
pattern: /\D/,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This regex pattern seems to match non-digit character. Is this correct?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is correct, the rules here are the same as when creating a cluster.

ui/src/pages/OBProxy/New/index.tsx Outdated Show resolved Hide resolved
ui/src/pages/OBProxy/helper.ts Outdated Show resolved Hide resolved
powerfooI
powerfooI approved these changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@powerfooI powerfooI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@powerfooI powerfooI merged commit 5e9bbc5 into oceanbase:master Jun 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powerfooI powerfooI powerfooI approved these changes

Assignees

@yang1666204 yang1666204

Labels
dashboard The issue or PR is related to oceanbase dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yang1666204 @powerfooI