Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor fn call waitForAqua to waitForIndexer #86

Merged
merged 3 commits into from
Jan 9, 2025
Merged

refactor fn call waitForAqua to waitForIndexer #86

merged 3 commits into from
Jan 9, 2025
+76 −23

Conversation

paulo-ocean
Copy link
Contributor

@paulo-ocean paulo-ocean commented Jan 8, 2025 •
edited
Loading

Fixes #85

Changes proposed in this PR:

  • refactor function call (waitForAqua is now waitForIndexer) (uses updated SDK not older versions)
  • possibility to set custom process.env variables for wait for indexing retry interval and number of retries

@paulo-ocean paulo-ocean self-assigned this Jan 8, 2025
@paulo-ocean paulo-ocean marked this pull request as ready for review January 9, 2025 10:29
mariacarmina
mariacarmina reviewed Jan 9, 2025
View reviewed changes
Copy link
Member

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looks good

src/publishAsset.ts Show resolved Hide resolved
mariacarmina
mariacarmina approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paulo-ocean paulo-ocean merged commit dd45fb6 into main Jan 9, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariacarmina mariacarmina mariacarmina approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas is a code owner

@jamiehewitt15 jamiehewitt15 Awaiting requested review from jamiehewitt15 jamiehewitt15 is a code owner

Assignees

@paulo-ocean paulo-ocean

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor usage of waitForAqua from SDK (refactored to wiatForIndexer)
2 participants
@paulo-ocean @mariacarmina