Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

del log of data.hash #3269

Merged
merged 1 commit into from
Dec 12, 2023
Merged

del log of data.hash #3269

merged 1 commit into from
Dec 12, 2023

Conversation

chengzhinei
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (3fdc51e) 36.54% compared to head (cdd4579) 36.53%.

❗ Current head cdd4579 differs from pull request most recent head 1937e06. Consider uploading reports for the commit 1937e06 to get more accurate results

Files Patch % Lines
app/rpc/namespaces/eth/tx_pool.go 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3269      +/-   ##
==========================================
- Coverage   36.54%   36.53%   -0.01%     
==========================================
  Files         446      446              
  Lines       46869    46869              
==========================================
- Hits        17126    17124       -2     
- Misses      28471    28472       +1     
- Partials     1272     1273       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangjianmeng xiangjianmeng merged commit f1ce92c into dev Dec 12, 2023
8 checks passed
@xiangjianmeng xiangjianmeng deleted the fix-txpool-dev branch December 12, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants