Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix counter script #1802

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Fix counter script #1802

merged 1 commit into from
Oct 25, 2024

Conversation

turbolent
Copy link
Member

Description

get count instead of non-existent greeting


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.47%. Comparing base (606ca7a) to head (30bce54).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1802   +/-   ##
=======================================
  Coverage   28.47%   28.47%           
=======================================
  Files          95       95           
  Lines        6490     6490           
=======================================
  Hits         1848     1848           
  Misses       4462     4462           
  Partials      180      180           
Flag Coverage Δ
unittests 28.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jribbink jribbink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jribbink jribbink merged commit 480428f into master Oct 25, 2024
5 checks passed
@jribbink jribbink deleted the bastian/fix-counter-script branch October 25, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants