Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the config missing message when running emulator #1835

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

chasefleming
Copy link
Member

@chasefleming chasefleming commented Nov 18, 2024

Closes #1789


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@chasefleming chasefleming added the Improvement Technical work without new features, refactoring, improving tests label Nov 18, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.47%. Comparing base (888f6d2) to head (278fc15).

Files with missing lines Patch % Lines
internal/emulator/start.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1835   +/-   ##
=======================================
  Coverage   28.47%   28.47%           
=======================================
  Files          95       95           
  Lines        6490     6490           
=======================================
  Hits         1848     1848           
  Misses       4462     4462           
  Partials      180      180           
Flag Coverage Δ
unittests 28.47% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@chasefleming chasefleming merged commit eb10911 into master Nov 18, 2024
7 checks passed
@chasefleming chasefleming deleted the cf/improve-msg branch November 18, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Technical work without new features, refactoring, improving tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helper text for flow emulator start is confusing if command is accidentally run from the wrong directory
3 participants