small optimization

onflow · Aug 13, 2024 · ba08d38 · ba08d38
1 parent 609eee7
commit ba08d38
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/cmd/execution_builder.go b/cmd/execution_builder.go
@@ -527,14 +527,12 @@ func (exeNode *ExecutionNode) LoadProviderEngine(
 
 	if exeNode.exeConf.evmTracingEnabled {
 		var err error
-		var evmTraceUploader debug.Uploader
+		evmTraceUploader := debug.NewNoopUploader()
 		if len(exeNode.exeConf.evmTracesGCPBucket) > 0 {
 			evmTraceUploader, err = debug.NewGCPUploader(exeNode.exeConf.evmTracesGCPBucket)
 			if err != nil {
 				return nil, fmt.Errorf("could not create evm trace uploader: %w", err)
 			}
-		} else {
-			evmTraceUploader = &debug.NoopUploader{}
 		}
 		evmTracer, err := debug.NewEVMCallTracer(evmTraceUploader, node.Logger)
 		if err != nil {

diff --git a/fvm/evm/debug/uploader.go b/fvm/evm/debug/uploader.go
@@ -59,6 +59,11 @@ func (g *GCPUploader) Upload(id string, data json.RawMessage) error {
 	return nil
 }
 
+// NewNoopUploader constructs a new noop uploader
+func NewNoopUploader() Uploader {
+	return &NoopUploader{}
+}
+
 type NoopUploader struct{}
 
 func (np *NoopUploader) Upload(id string, data json.RawMessage) error {