Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Util] Add a command to print all system addresses #6339

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

turbolent
Copy link
Member

Add a command similar to addresses, which prints the addresses of all system accounts, based on the information in the system contracts struct

@turbolent turbolent requested review from a team August 14, 2024 16:03
@turbolent turbolent force-pushed the bastian/add-util-system-addresses-command branch from ccba919 to de32486 Compare August 14, 2024 16:10
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 41.99%. Comparing base (eeac479) to head (de32486).

Files Patch % Lines
cmd/util/cmd/system-addresses/cmd.go 0.00% 24 Missing ⚠️
cmd/util/cmd/root.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6339      +/-   ##
==========================================
+ Coverage   41.18%   41.99%   +0.80%     
==========================================
  Files        1629     1628       -1     
  Lines      121427   118552    -2875     
==========================================
- Hits        50010    49780     -230     
+ Misses      66180    63606    -2574     
+ Partials     5237     5166      -71     
Flag Coverage Δ
unittests 41.99% <0.00%> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent turbolent enabled auto-merge August 14, 2024 16:29
Copy link
Contributor

@janezpodhostnik janezpodhostnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@turbolent turbolent added this pull request to the merge queue Aug 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 14, 2024
@turbolent turbolent added this pull request to the merge queue Aug 14, 2024
Merged via the queue into master with commit 611a8a7 Aug 14, 2024
55 checks passed
@turbolent turbolent deleted the bastian/add-util-system-addresses-command branch August 14, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants