-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using interface-converted type-requirement in fields #6341
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6341 +/- ##
==========================================
+ Coverage 41.46% 41.51% +0.04%
==========================================
Files 2011 2012 +1
Lines 143338 143437 +99
==========================================
+ Hits 59439 59544 +105
+ Misses 77729 77720 -9
- Partials 6170 6173 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
|
…/type-requirement-removal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work generalizing this! 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I'm also wondering if we can join the TypeRequirementsExtractingMigration
with an existing migration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
d0ce4fc
to
6736db4
Compare
…/type-requirement-removal
6736db4
to
aa2515d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Closes onflow/cadence#3527
(Solves https://flow-foundation.slack.com/archives/C074F78ECNL/p1723566139471899)
If a type-requirement has been converted to an interface, then allow using such updated type in field. i.e: allow changing the field types to the interface type. Here only
T
would become{T}
, and nothing else would be allowed.