[EFM] Recoverable Random Beacon State Machine follow up updates #6815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/efm-recovery #6815 +/- ##
========================================================
- Coverage 41.73% 39.25% -2.48%
========================================================
Files 2033 1356 -677
Lines 181223 126753 -54470
========================================================
- Hits 75632 49763 -25869
+ Misses 99364 72959 -26405
+ Partials 6227 4031 -2196
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jordanschalm
approved these changes
Dec 18, 2024
AlexHentschel
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
Looks great. Thanks for the detailed work and solid tests. My comments mostly fall into two categories:
- how we represent the underlying logic in code - in particular, we want to make it as easy as possible for somebody reading the code to convince themself of correctness (and which parts can be modified / extended without breaking correctness)
- clearly documenting under which conditions operations are idempotent and structuring the code accordingly for clarity.
Co-authored-by: Alexander Hentschel <[email protected]> Co-authored-by: Jordan Schalm <[email protected]>
…low/flow-go into yurii/6725-follow-up-changes
…tee cannot be committed in the Recoverable Random Beacon State Machine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR addresses some open comments from PR #6771.
Specifically:
By far the biggest change is how we insert/upsert keys, now caller needs to provide evidence in form of
EpochCommitso state machine can sanity check if it's inserting a valid private key.