Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add epoch configs as env variables to Benchnet2 Makefile #6855

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

jordanschalm
Copy link
Member

@jordanschalm jordanschalm commented Jan 8, 2025

This PR extracts epoch configs as env variables in BN2, allowing them to be overridden (see https://github.com/onflow/flow-go-internal/pull/7028).

@jordanschalm jordanschalm marked this pull request as ready for review January 8, 2025 00:21
@jordanschalm jordanschalm requested a review from Kay-Zee as a code owner January 8, 2025 00:21
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.19%. Comparing base (c6a1f97) to head (2769e66).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6855      +/-   ##
==========================================
+ Coverage   41.15%   41.19%   +0.03%     
==========================================
  Files        2065     2109      +44     
  Lines      182499   185664    +3165     
==========================================
+ Hits        75116    76485    +1369     
- Misses     101077   102768    +1691     
- Partials     6306     6411     +105     
Flag Coverage Δ
unittests 41.19% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jordanschalm jordanschalm enabled auto-merge January 8, 2025 22:52
@jordanschalm jordanschalm added this pull request to the merge queue Jan 9, 2025
Merged via the queue into master with commit 8ff124c Jan 9, 2025
56 checks passed
@jordanschalm jordanschalm deleted the jord/bn2-epoch-config branch January 9, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants