TestMessageIndexTransactionStatusesProviderResponse_HappyPath test being flaky. #6862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests to be stable because of txStatusesChan closing too soon
…pyPath tests to be stable because of txStatusesChan closing too soon" This reverts commit dfa54c0.
…eing flaky because of statusesChan closes to soon
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6862 +/- ##
==========================================
- Coverage 41.18% 41.17% -0.01%
==========================================
Files 2109 2109
Lines 185660 185664 +4
==========================================
- Hits 76467 76454 -13
- Misses 102782 102797 +15
- Partials 6411 6413 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jordanschalm
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
LGTM - thank you for the quick turnaround
% go test ./engine/access/rest/websockets/data_providers/... -testify.m ^TestMessageIndexTransactionStatusesProviderResponse_HappyPath$ -count 100
? github.com/onflow/flow-go/engine/access/rest/websockets/data_providers/mock [no test files]
ok github.com/onflow/flow-go/engine/access/rest/websockets/data_providers 1.107s
jordanschalm
requested review from
AlexHentschel,
durkmurder,
zhangchiqing,
peterargue,
Kay-Zee,
janezpodhostnik and
tarakby
as code owners
zhangchiqing
approved these changes
Jan 9, 2025
durkmurder
approved these changes
Jan 9, 2025
engine/access/rest/websockets/data_providers/transaction_statuses_provider_test.go
Outdated
Show resolved
Hide resolved
thanks for pointing this out. |
…tatusesProviderResponse_HappyPath-fix-flaky-test
AndriiDiachuk
deleted the
AndriiDiachuk/TestMessageIndexTransactionStatusesProviderResponse_HappyPath-fix-flaky-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue with
TestMessageIndexTransactionStatusesProviderResponse_HappyPathtest being flaky : #6850 (comment)The
txStatusesChanchannel is being closed after all data is sent in the separate goroutine. Depending on the exact timing of goroutines, the provider may detect the closed channel and call theErrmethod to check for errors. If this happens after the test finishes or the expectations are incomplete, the mocked call toErrmay not be registered properly.Synchronized Goroutines by added a done channel to wait for the provider's Run method to finish before concluding the test.