Skip to content

Commit

Permalink
x
Browse files Browse the repository at this point in the history
  • Loading branch information
bassosimone committed Jun 28, 2024
1 parent 9fdc61f commit 5d34280
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions pkg/oonimkall/taskrunner.go
Original file line number Diff line number Diff line change
Expand Up @@ -309,15 +309,6 @@ func (r *runnerForTask) Run(rootCtx context.Context) {
}

// Perform the measurement proper.
//
// Richer input implementation note: in mobile, we only observe richer input
// for Web Connectivity and only store this kind of input into the database and
// otherwise we ignore richer input for other experiments, which are just
// treated as experimental. As such, the thinking here is that we do not care
// about *passing* richer input from desktop to mobile for some time. When
// we will care, it would most likely suffice to require the Inputs field to
// implement in Java the [model.ExperimentTarget] interface, which is something
// we can always do, since it only has string accessors.
m, err := experiment.MeasureWithContext(
r.contextForExperiment(measCtx, builder),
target,
Expand Down

0 comments on commit 5d34280

Please sign in to comment.