Picciotto et al. 1960 isotopic temperature inference formula (journal club paper)

[slayoo]

No description provided.

[codecov]

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.23%. Comparing base (824a94d) to head (364b053).

Files with missing lines	Patch %	Lines
...tope_temperature_inference/picciotto_et_al_1960.py	83.33%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1498   +/-   ##
=======================================
  Coverage   85.22%   85.23%           
=======================================
  Files         376      378    +2     
  Lines        9266     9277   +11     
=======================================
+ Hits         7897     7907   +10     
- Misses       1369     1370    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[AgnieszkaZaba]

@slayoo
I tested fig_2 with changing delta_180 with delta_deuterium. For me it looks similar but need to add actual tests.
I can easily add it as a new commit if you want.

[AgnieszkaZaba]

New test for fig_2 that is just for plotting and need some assert.

def test_fig_2(plot=True):
    # arrange
    formulae = Formulae(isotope_temperature_inference="PicciottoEtAl1960")
    delta_18O = np.linspace(-35, -13) * PER_MILLE
    # act
    delta_deuterium = formulae.isotope_temperature_inference.temperature_from_delta_deuterium(
        in_unit(delta_18O, PER_MILLE)
    )
    
    # plot
    pyplot.figure(figsize=(5, 6))
    for side in ("top", "right"):
        pyplot.gca().spines[side].set_visible(False)
    pyplot.plot(in_unit(delta_deuterium, PER_CENT), in_unit(delta_18O, PER_MILLE), color="k")

    pyplot.xlabel("$\Delta$ D [%]")
    pyplot.xlim(-35, -10)
    pyplot.xticks(range(-35, -10, 5))

    pyplot.ylabel("δ$^{18}$O [‰]")
    pyplot.ylim(in_unit(delta_18O[0], PER_MILLE), in_unit(delta_18O[-1], PER_MILLE))
    pyplot.yticks(range(-35, -10, 5))

    pyplot.grid(color="k")
    pyplot.savefig("pysdm_fig2.pdf")
    if plot:
        pyplot.show()
    else:
        pyplot.clf()

[AgnieszkaZaba]

@staticmethod
    def temperature_from_delta_deuterium(const, delta_180):
        return const.PICCIOTTO_180_TO_DEUTERIUM_A * delta_180 - const.PICCIOTTO_180_TO_DEUTERIUM_B

[AgnieszkaZaba]

I see that I change it to minus B. Hmmm I need to add tests to properly check it

[AgnieszkaZaba]

PICCIOTTO_180_TO_DEUTERIUM_A = 0.8 * PER_CENT
PICCIOTTO_180_TO_DEUTERIUM_B = 1.8 * PER_CENT