Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaned up Glossary and added "OCM Coordinates" term #113
Cleaned up Glossary and added "OCM Coordinates" term #113
Changes from 2 commits
3efe0b5
78809cf
15cd1a4
df1adec
35ae079
597e41e
7c810e7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the linked content. Maybe we copy the text from the mail to here. The Component name should be added as own entry in the glossar, too, and also linked, same as the component version.
The Component identity consists of
Component Name: identifies component. Should follow conventions similar to DNS (start with URL-prefix controlled by Component-Owner)
Component Version: if used with a component name, identifies a specific Component Version. Must adhere to "relaxed Semver" (major, minor (+optional patchlevel) - optional v-prefix).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
considering the wording, I think
immutable
is not quite adequate. I think it would be better to call this formstable
(iff [sic!] no content changes occur, the normalised form will remain unchanged).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the OCM coordinates will become a central term, I guess we can take over the full text of the mail to the glossary, although it contains many other definitions. This makes it easier to consume all information at one place without having the need to follow the links. @n-boshnakov what do you think?
OCM Coordinates are used to reference OCM Component Versions and artefacts within OCM Component Versions. Coordinates referring to an OCM Component Version are also called
Component Identity
, whereas relative coordinates referring to an artefact are calledArtefact Identity
.Component Identities
are globally unique and may be used to refer to full Component Versions.Artefact Identities
are always relative to an OCM Component Version and may only be used in conjunction with a Component Identity.In detail:
Component Identity
Artefact Identity
Within a Component Version, all artefacts must have a unique identity. The identity always includes:
Artefacts may also have additional attributes (called extraIdentity) that contribute to their identities. extraIdentity attributes are string-to-string maps.
Examples
Assuming there is a component named
example.org/my-component
, with two versions1.2.3
and1.3.0
, declaring a resource namedmy-resource
, then the following OCM Coordinates can be used to reference different things:example.org/my-component
: all versions of the component (1.2.3 + 1.3.0)example.org/my-component:1.2.3
: version 1.2.3 of the componentexample.org/my-component:1.2.3:resource/my-resource
:my-resource
as declared by the component versionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The glossary should be a place for short definitions only. What we could do is take the content of the email and place it in a separate topic, then link to it from the term.
As the content of the email is already formatted in Markdown, this leads me to believe that it already exists somewhere as a topic, therefore we could just link to it. If that is not true, however, I could create a new topic with that content in this repository and link to it instead. I just need to know the correct folder to place the topic in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@n-boshnakov : it is formatted in markdown mostly because I write in markdown(-ish) as a habit. the text was written ad-hoc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, I think it would be best if this information is placed in a repo as a topic. We can then link it to the new term being introduced for ease of access.