Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Cleaning and Linters #397

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Code Cleaning and Linters #397

wants to merge 13 commits into from

Conversation

FlorianK13
Copy link
Member

@FlorianK13 FlorianK13 commented Jan 11, 2025

Linting

  • Add prettier as dev dependency
  • Save all linter config in .prettierrc.yml
  • Create new npm command: npm run format will run the prettier linter on all files in the repo
  • Done this once to make all files linter conform
  • Created a linting github action that runs for PRs on main

Deleting unused dependencies and functions

  • Identified dependency paco as unused
  • Found several functions and variables that were never used and deleted them. I used eslint to find those variables.

Changing CRLF to LF probably explains the huge size of this PR.

@FlorianK13 FlorianK13 linked an issue Jan 11, 2025 that may be closed by this pull request
@FlorianK13 FlorianK13 marked this pull request as ready for review January 11, 2025 15:34
@FlorianK13 FlorianK13 requested a review from khdlr January 11, 2025 16:00
@FlorianK13
Copy link
Member Author

@khdlr real Review will not work here, as almost all files changed. Are you happy with all the changes as described above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regular code cleaning session
1 participant