Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed The issue with sumatra repeat and diff (only git) #356

Merged
merged 4 commits into from
Sep 10, 2017
Merged

Fixed The issue with sumatra repeat and diff (only git) #356

merged 4 commits into from
Sep 10, 2017

Conversation

maharjun
Copy link
Contributor

This is in reference to issue #354. I have implemented a fix as follows

  1. Added the functions reset and patch to the WorkingCopy Interface and implemented them for git, unfortunately I do not have any experience with the other API's and so I cannot implement them
  2. Updated update_code to take a diff string as an argument and apply diffs
  3. Updated the Record.launch function to take diff as a keyword argument so that diff stored code can also be launched.
  4. Updated the Project.Repeat function to reset the diff along with commit version at the end of run.

@apdavison apdavison added this to the 0.8 milestone Sep 10, 2017
@apdavison
Copy link
Contributor

apdavison commented Sep 10, 2017 •
edited
Loading

This could do with some tests, but I will implement them as part of extending this to the other version control systems (#365)

@apdavison apdavison mentioned this pull request Sep 10, 2017
Open
@apdavison apdavison merged commit b182773 into open-research:master Sep 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug versioncontrol module
Projects
None yet
Milestone
0.8
Development

Successfully merging this pull request may close these issues.
2 participants
@maharjun @apdavison