Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTAINER] Add devcontainer #3123

Merged
merged 16 commits into from
Jan 15, 2025
Merged

Conversation

esigo
Copy link
Member

@esigo esigo commented Nov 5, 2024

Fixes #3118 (issue)

Changes

bazelisk-linux-amd64 test --copt=-DENABLE_LOGS_PREVIEW --test_output=errors --cache_test_results=no --copt=-DENABLE_TEST //exporters/otlp/...

bash ci/do_ci.sh cmake.exporter.otprotocol.test

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@esigo esigo requested a review from a team as a code owner November 5, 2024 18:43
Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 5f5909b
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/6788217838d42d0008815035

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.71%. Comparing base (95baed7) to head (5f5909b).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3123   +/-   ##
=======================================
  Coverage   87.71%   87.71%           
=======================================
  Files         198      198           
  Lines        6271     6271           
=======================================
  Hits         5500     5500           
  Misses        771      771           

CONTRIBUTING.md Show resolved Hide resolved
ci/README.md Show resolved Hide resolved
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the tooling and doc.

@marcalff marcalff changed the title Add devcontainer [MAINTAINER] Add devcontainer Jan 15, 2025
@marcalff marcalff merged commit 465cb4a into open-telemetry:main Jan 15, 2025
57 checks passed
@esigo esigo deleted the 3118-devcontainer branch January 16, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instructions for running CI tests locally via Docker do not work
6 participants