-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Implement spec: MetricFilter #3235
base: main
Are you sure you want to change the base?
Conversation
|
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
bbd4ca5
to
9e8e4b7
Compare
d6f5504
to
1473ebe
Compare
Thanks for the PR. Please remember to sign the EasyCLA, so this PR can be processed. |
e0d8498
to
9c3f930
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3235 +/- ##
==========================================
- Coverage 88.16% 87.86% -0.30%
==========================================
Files 198 199 +1
Lines 6224 6346 +122
==========================================
+ Hits 5487 5575 +88
- Misses 737 771 +34
|
a36ed14
to
a4384fa
Compare
@IcySteam Thanks for the PR. I believe you are working to get the CLA signed, as the PR can't be reviewed without that. |
a4384fa
to
4bff481
Compare
4bff481
to
7b19eb4
Compare
Fixes #2447
Changes
This PR implements the MetricFilter spec in
opentelemetry-cpp
.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changesMetricProducer::MetricProducer
MetricCollector::MetricCollector
MeterContext::AddMetricReader
MeterProvider::AddMetricReader