Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that spec front matter redirect path gets patched too #6027

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jan 22, 2025

  • Followup to Update opentelemetry-specification version to v1.41.0 #6022
  • Ensures that path patch gets applied to path in front matter too. Currently we get a 404:
    $ curl -sIL https://opentelemetry.io/docs/specs/otel/common/attribute-naming/ | grep -E 'HTTP|^date|loc'
    HTTP/2 301 
    date: Wed, 22 Jan 2025 13:51:50 GMT
    location: /docs/specs/semconv/general/naming/
    HTTP/2 404 
    date: Wed, 22 Jan 2025 13:51:50 GMT

This PR also patches the redirect path:

$ curl -sIL https://deploy-preview-6027--opentelemetry.netlify.app/docs/specs/otel/common/attribute-naming/ | grep -E 'HTTP|^date|loc' 
HTTP/2 301 
date: Wed, 22 Jan 2025 13:53:43 GMT
location: /docs/specs/semconv/general/attribute-naming/
HTTP/2 200 
date: Wed, 22 Jan 2025 13:53:43 GMT

Preview: https://deploy-preview-6027--opentelemetry.netlify.app/docs/specs/otel/common/attribute-naming/

@chalin chalin added CI/infra CI & infrastructure sig:spec labels Jan 22, 2025
@chalin chalin requested a review from a team as a code owner January 22, 2025 13:49
@chalin chalin merged commit 65e2140 into open-telemetry:main Jan 22, 2025
17 checks passed
@chalin chalin deleted the chalin-im-spec-patch-redirect-2025-01-22 branch January 22, 2025 14:02
@chalin
Copy link
Contributor Author

chalin commented Jan 22, 2025

Might follow through with:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure sig:spec
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants