Added contactable to tracks #2541
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2541 +/- ##
===========================================
- Coverage 76.46% 61.62% -14.85%
===========================================
Files 146 146
Lines 4810 5016 +206
===========================================
- Hits 3678 3091 -587
- Misses 1132 1925 +793
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## GSoC19 #2541 +/- ##
==========================================
+ Coverage 82.29% 82.33% +0.04%
==========================================
Files 147 147
Lines 4795 4801 +6
==========================================
+ Hits 3946 3953 +7
+ Misses 849 848 -1
Continue to review full report at Codecov.
|
|
Please do correct me if I am wrong, but I don't think we are providing an option for people to submit information such as the project's source code location or the project's license. |
|
@differentreality The Social Media fields covers the different platforms and yes there is no specific fields for the code repository. I intended to have a website_url, email , github/repo fields in the track model itself and use the contact model for capture the media platforms. But I liked the idea for project license, but should we add a special field for this? The other information apart from these in the track submission that I propose are : :track_type - which can be selected from a drop down with choices much like event_types which I will cover in my next PR. These are the details that I am planning to include in the submission from the users for tracks. |
db/schema.rb
Outdated
| ActiveRecord::Schema.define(version: 20190612161235) do | ||
|
|
||
| # These are extensions that must be enabled in order to support this database | ||
| enable_extension "plpgsql" |
There was a problem hiding this comment.
Why is this here? In general, why does this file have that many changes?
There was a problem hiding this comment.
I think some unwanted changes were introduced during db migrations . I will check it again in my new PR against the GSoC19 branch.
|
@rishabhptr so what are you suggesting for the other links we want to show (email, license, etc)? Add fields in Track model? And then in Booth model? |
|
@differentreality As of now yes, any specific field like email, website/license which we can identify would go in the track/booth model itself. |
|
@differentreality can we get this merged or are there still concerns? @rishabh92 can you please rebase? there are some commits that shouldn't be here. We should fix #2540 because is blocking the PRs as well. |
|
@rishabhptr please keep an eye out on Travis and fix the linters failures, we cannot merge ortherwise! |
|
@differentreality I have fixed the linters, but the feature test were failing due to the webdriver issue which is now resolved in master. Maybe we should bring in the latest changes to the GSoC19 branch? |
@Ana06 not concerns per se, but we will probably need to use the same fields for Booth as well. |
rishabhptr
force-pushed
the
contactable
branch
2 times, most recently
from
769fc41 to
4232dd8
Compare
|
Screenshots would be helpful here too 😉 |
|
@rishabhptr please rebase |
Added social media fields to track submission form by using a polymorphic association with the Contact Model.
|
@differentreality Yes, the form is quite longer now. Maybe we could ask for the other fields at a later stage. Right now when the track is accepted and then confirmed by the submitter, the user is able to manage his track but he cannot edit the details as it make sense to not change them after submission. However, we can include the option to add fields such as social media in a separate tab in the show page. So that the user can update these details there.
As for booths, we can allow the user to edit his submission add these additional information upon being accepted and not before. |
Related to #2528
I have tried couple of different ways to use the contact model for social media fields. I have chosem this approach so as to enable for the user to add all fields at the same time in a single form while creating the track using nested attributes.
Also, as
contactmodel has ahas_onerelationship withconferencemodel I need to pass theconference_idas it is mandatory but I believe this will break the previous mechanism where a conference had one contact which could be fetched to show on the splashpage. So we would need to modify this relationship as well.At this point I need to decide if I should use this model or just add the social fields in the main Track/Booth model itself.
Apart from this other fields like :code_of_conduct_accepted, :additional_requirements etc are pretty straightforward and after this I can work on the different views related to these details.