Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake improvements #587

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

CMake improvements #587

wants to merge 4 commits into from

Conversation

gruenich
Copy link
Contributor

  • Make code follow modern style guides
  • Improve find modules

@gruenich
[cmake] Remove arguments in in else(), endif(), endforloop()
29a208d 
Uncommon, difficult to read and discouraged style.
@gruenich
[cmake] Reduce multiple calls to enable_testing()
59963b0 
include(CTest) has the same effect
@gruenich
[cmake] Use FindPackageHandleStandardArgs in find modules
af0ba7e 
Ensures CMake configure run is really stopped if REQUIRED dependency
is not found.
@gruenich
[cmake] No need for manual check for caching
d4db566 
CMake already caches find_file and find_library calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gruenich