Merge pull request #7948 from opencrvs/fix/knip-error-swallowed

Fix/knip error swallowed
opencrvs · Nov 11, 2024 · 99534e5 · 99534e5
2 parents 3c6cc37 + 02a96b6
commit 99534e5
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 25 deletions.
diff --git a/.github/workflows/lint-and-test.yml b/.github/workflows/lint-and-test.yml
@@ -152,27 +152,30 @@ jobs:
         run: |
           cat << 'EOF' > knip-reporter.js
           const reporter = function (options) {
-            const totalIssues = Object.values(options.issues).reduce(
-              (acc, issueRecords) =>
-                acc + Object.values(issueRecords).reduce(
-                  (acc2, issuesInFile) => acc2 + Object.keys(issuesInFile).length,
-                  0
-                ),
+            const totalIssues = Object.entries(options.counters).reduce(
+              (acc, [key, value]) => {
+                if (options.report[key]) {
+                  return acc + value
+                }
+
+                return acc
+              },
               0
-            );
-            console.log(JSON.stringify({ totalIssues }));
-          };
-          export default reporter;
+            )
+
+            console.log(JSON.stringify({ totalIssues }))
+          }
+          export default reporter
           EOF
       - name: Run knip on base branch
         id: knip_base
         run: |
           OUTPUT=$(npx knip --no-exit-code --exports --reporter=./knip-reporter.js)
           JSON=$(echo "$OUTPUT" | grep -o '{.*}')
           total_issues=$(echo "$JSON" | jq '.totalIssues')
-          echo "Total Issues: $total_issues"
+          echo "Found $total_issues issue(s) on base branch."
+          echo "Setting $total_issues issue(s) as max limit for PR branch."
           echo "maxIssues=${total_issues}" >> $GITHUB_OUTPUT
-          echo "Max issues = $maxIssues"
 
       - name: Checkout the PR branch
         uses: actions/checkout@v2
@@ -185,18 +188,20 @@ jobs:
         run: |
           cat << 'EOF' > knip-reporter.js
           const reporter = function (options) {
-            const totalIssues = Object.values(options.issues).reduce(
-              (acc, issueRecords) =>
-                acc + Object.values(issueRecords).reduce(
-                  (acc2, issuesInFile) => acc2 + Object.keys(issuesInFile).length,
-                  0
-                ),
+            const totalIssues = Object.entries(options.counters).reduce(
+              (acc, [key, value]) => {
+                if (options.report[key]) {
+                  return acc + value
+                }
+
+                return acc
+              },
               0
-            );
-            console.log(JSON.stringify({ totalIssues }));
-          };
-          export default reporter;
+            )
+
+            console.log(JSON.stringify({ totalIssues }))
+          }
+          export default reporter
           EOF
       - name: Run knip on PR branch
-        run: |
-          npx knip --max-issues=${{ steps.knip_base.outputs.maxIssues }} --exports --reporter=./knip-reporter.js
+        run: npx knip --max-issues=${{ steps.knip_base.outputs.maxIssues }} --exports --reporter=./knip-reporter.js
diff --git a/packages/gateway/package.json b/packages/gateway/package.json
@@ -17,7 +17,7 @@
     "gen:schema:watch": "nodemon --quiet --on-change-only -e graphql -i src/graphql/schema.graphql -x 'yarn gen:schema'",
     "gen:types:watch": "nodemon --quiet --on-change-only -w src/graphql/schema.graphql -x 'yarn gen:types'",
     "open:cov": "yarn test && opener coverage/index.html",
-    "lint": "eslint -c .eslintrc.js --fix ./src"
+    "lint": "eslint -c .eslintrc.js --fix ./src --max-warnings=0"
   },
   "dependencies": {
     "@elastic/elasticsearch": "8.13.1",