Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events v2: implement deduplication configuration #8329

Merged
merged 11 commits into from
Jan 14, 2025
Merged

Events v2: implement deduplication configuration #8329

merged 11 commits into from
Jan 14, 2025

Conversation

rikukissa
Copy link
Member

@rikukissa rikukissa commented Jan 13, 2025 •
edited
Loading

@github-actions GitHub Actions
Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

rikukissa
rikukissa commented Jan 13, 2025
View reviewed changes
packages/events/src/service/deduplication/deduplication.test.ts
@@ -0,0 +1,398 @@
/*
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests copied from legacy birth deduplication. You can see how deduplication logic is configured starting from line 24

makelicious
makelicious approved these changes Jan 14, 2025
View reviewed changes
packages/commons/src/events/DeduplicationConfig.ts Outdated Show resolved Hide resolved
packages/commons/src/events/DeduplicationConfig.ts Show resolved Hide resolved
packages/events/src/service/deduplication/deduplication.test.ts Outdated Show resolved Hide resolved
packages/events/src/service/deduplication/deduplication.test.ts Show resolved Hide resolved
packages/events/src/service/deduplication/deduplication.test.ts Outdated Show resolved Hide resolved
packages/events/src/service/deduplication/deduplication.ts Outdated Show resolved Hide resolved
packages/events/src/service/deduplication/deduplication.ts Show resolved Hide resolved
packages/events/src/service/deduplication/deduplication.ts Show resolved Hide resolved
packages/events/src/service/events.ts Outdated Show resolved Hide resolved
packages/events/src/service/events.ts Outdated Show resolved Hide resolved
@rikukissa rikukissa enabled auto-merge (squash) January 14, 2025 13:13
@rikukissa rikukissa added the 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it label Jan 14, 2025
@rikukissa rikukissa force-pushed the events-v2-configurable-deduplication branch from add0282 to 7eafed4 Compare January 14, 2025 13:14
@rikukissa rikukissa deployed to events-v2-configurable-deduplicatio January 14, 2025 13:14 — with GitHub Actions Active
@rikukissa rikukissa merged commit 6621237 into develop Jan 14, 2025
53 of 55 checks passed
@euanmillar euanmillar mentioned this pull request Jan 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamil314 jamil314 jamil314 approved these changes

@makelicious makelicious makelicious approved these changes

Assignees
No one assigned
Labels
🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rikukissa @makelicious @jamil314