chore: clean up existing mosip code

opencrvs · Nov 6, 2024 · ff54fbd · ff54fbd
1 parent 7741fb1
commit ff54fbd
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 75 deletions.
diff --git a/src/api/certificates/source/Farajaland-birth-certificate-v2.svg b/src/api/certificates/source/Farajaland-birth-certificate-v2.svg
diff --git a/src/form/birth/index.ts b/src/form/birth/index.ts
@@ -66,8 +66,7 @@ import {
   informantFirstNameConditionals,
   informantFamilyNameConditionals,
   informantBirthDateConditionals,
-  exactDateOfBirthUnknownConditional,
-  hideIfNidIntegrationEnabled
+  exactDateOfBirthUnknownConditional
 } from '../common/default-validation-conditionals'
 import {
   documentsSection,
@@ -266,12 +265,12 @@ export const birthForm: ISerializedForm = {
             getIDType(
               'birth',
               'informant',
-              hideIfNidIntegrationEnabled.concat(hideIfInformantMotherOrFather),
+              hideIfInformantMotherOrFather,
               true
             ),
             ...getIDNumberFields(
               'informant',
-              hideIfNidIntegrationEnabled.concat(hideIfInformantMotherOrFather),
+              hideIfInformantMotherOrFather,
               true
             ),
             // ADDRESS FIELDS WILL RENDER HERE
@@ -335,17 +334,8 @@ export const birthForm: ISerializedForm = {
               certificateHandlebars.motherNationality,
               detailsExist
             ), // Required field.
-            getIDType(
-              'birth',
-              'mother',
-              hideIfNidIntegrationEnabled.concat(detailsExist),
-              true
-            ),
-            ...getIDNumberFields(
-              'mother',
-              hideIfNidIntegrationEnabled.concat(detailsExist),
-              true
-            ),
+            getIDType('birth', 'mother', detailsExist, true),
+            ...getIDNumberFields('mother', detailsExist, true),
             // ADDRESS FIELDS WILL RENDER HERE
             divider('mother-address-seperator', detailsExist),
             getMaritalStatus(certificateHandlebars.motherMaritalStatus, [
@@ -422,17 +412,8 @@ export const birthForm: ISerializedForm = {
               certificateHandlebars.fatherNationality,
               detailsExist
             ), // Required field.
-            getIDType(
-              'birth',
-              'father',
-              hideIfNidIntegrationEnabled.concat(detailsExist),
-              true
-            ),
-            ...getIDNumberFields(
-              'father',
-              hideIfNidIntegrationEnabled.concat(detailsExist),
-              true
-            ),
+            getIDType('birth', 'father', detailsExist, true),
+            ...getIDNumberFields('father', detailsExist, true),
             // ADDRESS FIELDS WILL RENDER HERE
             divider('father-address-seperator', detailsExist),
             getMaritalStatus(certificateHandlebars.fatherMaritalStatus, [

diff --git a/src/form/common/default-validation-conditionals.ts b/src/form/common/default-validation-conditionals.ts
@@ -31,20 +31,6 @@ export const isValidChildBirthDate = [
   }
 ] satisfies Validator[]
 
-export const hideIfNidIntegrationDisabled = [
-  {
-    action: 'hide',
-    expression: `const nationalIdSystem =
-    offlineCountryConfig &&
-    offlineCountryConfig.systems.find(s => s.integratingSystemType === '${IntegratingSystemType.Mosip}');
-    !nationalIdSystem ||
-    !nationalIdSystem.settings.openIdProviderBaseUrl ||
-    !nationalIdSystem.settings.openIdProviderClientId ||
-    !nationalIdSystem.settings.openIdProviderClaims;
-  `
-  }
-]
-
 export const detailsExistConditional: Conditional[] = [
   {
     action: 'hide',
@@ -394,20 +380,6 @@ export function getNationalIDValidators(configCase: string): Validator[] {
   }
 }
 
-export const hideIfNidIntegrationEnabled = [
-  {
-    action: 'hide',
-    expression: `const nationalIdSystem =
-          offlineCountryConfig &&
-          offlineCountryConfig.systems.find(s => s.integratingSystemType === '${IntegratingSystemType.Mosip}');
-          nationalIdSystem &&
-          nationalIdSystem.settings.openIdProviderBaseUrl &&
-          nationalIdSystem.settings.openIdProhideIfNidIntegrationDisabledviderClientId &&
-          nationalIdSystem.settings.openIdProviderClaims;
-      `
-  }
-]
-
 export const informantBirthDateConditionals = [
   {
     action: 'hide',

diff --git a/src/form/death/index.ts b/src/form/death/index.ts
@@ -61,8 +61,7 @@ import {
   spouseBirthDateConditionals,
   spouseFamilyNameConditionals,
   spouseFirstNameConditionals,
-  hideIfInformantSpouse,
-  hideIfNidIntegrationEnabled
+  hideIfInformantSpouse
 } from '../common/default-validation-conditionals'
 import {
   documentsSection,
@@ -291,17 +290,8 @@ export const deathForm = {
               certificateHandlebars.informantNationality,
               hideIfInformantSpouse
             ),
-            getIDType(
-              'death',
-              'informant',
-              hideIfNidIntegrationEnabled.concat(hideIfInformantSpouse),
-              true
-            ),
-            ...getIDNumberFields(
-              'informant',
-              hideIfNidIntegrationEnabled.concat(hideIfInformantSpouse),
-              true
-            ),
+            getIDType('death', 'informant', hideIfInformantSpouse, true),
+            ...getIDNumberFields('informant', hideIfInformantSpouse, true),
             // ADDRESS FIELDS WILL RENDER HERE
             divider('informant-address-separator', hideIfInformantSpouse),
             registrationPhone,
@@ -419,7 +409,7 @@ export const deathForm = {
             ), // Required field.
             getNationalID(
               'iD',
-              hideIfNidIntegrationEnabled.concat(detailsExist),
+              detailsExist,
               getNationalIDValidators('mother'),
               certificateHandlebars.motherNID
             ),
@@ -492,7 +482,7 @@ export const deathForm = {
             ), // Required field.
             getNationalID(
               'iD',
-              hideIfNidIntegrationEnabled.concat(detailsExist),
+              detailsExist,
               getNationalIDValidators('father'),
               certificateHandlebars.fatherNID
             ),