feat: check version compatibility with core #236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rikukissa
reviewed
Aug 14, 2024
Comment on lines
+536
to
+548
| const coreVersion = request.headers['x-version'] | ||
| const countryConfigVersion = process.env.npm_package_version | ||
| if ( | ||
| coreVersion && | ||
| coreVersion !== 'undefined' && | ||
| countryConfigVersion && | ||
| countryConfigVersion !== 'undefined' && | ||
| coreVersion !== countryConfigVersion | ||
| ) { | ||
| const errorMessage = `Version mismatch!! Opencrvs-Core is running on: ${coreVersion}, Opencrvs-Countryconfig is running on: ${countryConfigVersion}` | ||
| console.error(errorMessage) | ||
| return h.response({ message: errorMessage }).code(426).takeover() | ||
| } |
There was a problem hiding this comment.
Suggested change
| const coreVersion = request.headers['x-version'] | |
| const countryConfigVersion = process.env.npm_package_version | |
| if ( | |
| coreVersion && | |
| coreVersion !== 'undefined' && | |
| countryConfigVersion && | |
| countryConfigVersion !== 'undefined' && | |
| coreVersion !== countryConfigVersion | |
| ) { | |
| const errorMessage = `Version mismatch!! Opencrvs-Core is running on: ${coreVersion}, Opencrvs-Countryconfig is running on: ${countryConfigVersion}` | |
| console.error(errorMessage) | |
| return h.response({ message: errorMessage }).code(426).takeover() | |
| } |
I'm thinking we could make an assumption here that the client is always up to date as its core's responsibility to verify it. One of our design goals is to hide country config completely behind gateway which would also eliminate this issue
|
closing this in favor of previous comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.