Always retry mongo-on-update on failure #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
while I was testing 1.6.0, I noticed my staging environment not working. When trying to reset and seed the environment, I noticed reset not working as there was no replica set initialised in MongoDB. What had happened was this service failing for whatever reason. Kicking it back up and then doing a reset fixed the issue
On Hetzner (Ubuntu 24.04.1 LTS 6.8.0-45-generic) this was not the case
This comment has been minimized.
This comment has been minimized.
Zangetsu101
approved these changes
Nov 15, 2024
|
LGTM, curious about the |
n1koo
approved these changes
Nov 15, 2024
|
The machine was Ubuntu 24.04.1 LTS 6.8.0-45-generic on Hetzner. I left that info in the commit message 👍 |
rikukissa
added a commit
that referenced
this pull request
Nov 15, 2024
Co-authored-by: Riku Rouvila <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor improvements for things I found while testing 1.6.0 infrastructure.
While I was testing 1.6.0, I noticed my staging environment not working. When trying to reset and seed the environment, I noticed reset not working as there was no replica set initialised in MongoDB. What had happened was this service failing for whatever reason. Kicking it back up and then doing a reset fixed the issue.