Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable] Add logic on nbc-webhook to pickup internal or external registry #332

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #329

/assign harshad16

Copy link

openshift-ci bot commented May 23, 2024

Hi @openshift-cherrypick-robot. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@harshad16
Copy link
Member

/ok-to-test
/lgtm
/approve

Copy link

openshift-ci bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshad16 harshad16 merged commit 38cbf12 into opendatahub-io:stable May 23, 2024
1 of 2 checks passed
harshad16 pushed a commit to harshad16/odh-kubeflow that referenced this pull request May 31, 2024
…stry (opendatahub-io#332)

* Add logic on nbc-webhook to pickup internal or external registry

* create a temporary kubeconfig file for the test setup

* Pass kubeconfig as parameter,and handle the scenario of no namespaces that include the imagestream

---------

Co-authored-by: atheo89 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants