🐛 fixup correlation-id log for grpc calls #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #206 +/- ##
==========================================
+ Coverage 63.04% 63.35% +0.30%
==========================================
Files 28 28
Lines 1751 1763 +12
Branches 217 218 +1
==========================================
+ Hits 1104 1117 +13
Misses 541 541
+ Partials 106 105 -1 ☔ View full report in Codecov by Sentry. |
|
(Tests failed because of bug fixed by #207) |
dtrifiro
reviewed
Jan 15, 2025
|
unfortunately the automated precommit update caused some unrelated changes here |
Signed-off-by: Joe Runde <[email protected]>
Signed-off-by: Joe Runde <[email protected]>
dtrifiro
force-pushed
the
correlation-id-fix
branch
2 times, most recently
from
2fc9a26 to
b896b9e
Compare
|
Rebased on #209 |
dtrifiro
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a goof I made with the
x-correlation-idgrpc metadata header.I added a unit test this time so I don't break it again 😉