Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate Python config files #1104

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Consolidate Python config files #1104

wants to merge 2 commits into from

Conversation

mattwthompson
Copy link
Member

Description

I don't like TOML

@codecov Codecov
Copy link

codecov bot commented Nov 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.63%. Comparing base (8d2cee1) to head (fe2348e).

Additional details and impacted files

@mattwthompson mattwthompson force-pushed the consolidate-config branch 3 times, most recently from 04a4ed8 to 92f5cc4 Compare November 13, 2024 17:36
@mattwthompson
Copy link
Member Author

Unfortunately, is looking at openff/interchange/foyer/*.py and not the proper location when doing from foyer import ...

This is probably the cause?

[tool.setuptools.packages.find]
where = ["openff/interchange"]

@mattwthompson mattwthompson marked this pull request as ready for review November 14, 2024 23:02
@mattwthompson mattwthompson force-pushed the consolidate-config branch 6 times, most recently from 9ae2ae6 to b5639f0 Compare January 16, 2025 19:37
@mattwthompson mattwthompson marked this pull request as draft January 16, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-wags j-wags j-wags approved these changes

Assignees

@mattwthompson mattwthompson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattwthompson @j-wags