Introduce filestorage app, support for multiple file backends and store file metadata in the database
#1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: QF-2760 Keep the file metadata in the database |
suricactus
force-pushed
the
QF-2760-files
branch
from
895f958 to
59dba4d
Compare
gounux
reviewed
Jan 16, 2025
Comment on lines
-41
to
-51
| STORAGE_ACCESS_KEY_ID=minioadmin | ||
| STORAGE_SECRET_ACCESS_KEY=minioadmin | ||
| STORAGE_BUCKET_NAME=qfieldcloud-local | ||
| STORAGE_REGION_NAME= | ||
|
|
||
| # URL to the storage endpoint either minio, or external (e.g. S3). | ||
| # The URL must be reachable both from within docker and from the host, the default value is the `bridge` docker URL. | ||
| # Read more on https://docs.docker.com/network/network-tutorial-standalone/ . | ||
| # NOTE: to use minio on windows/mac, change the value to "http://host.docker.internal:8009" | ||
| # DEFAULT: http://172.17.0.1:8009 | ||
| STORAGE_ENDPOINT_URL=http://172.17.0.1:8009 |
There was a problem hiding this comment.
These env variables seem to be mandatory in order to set up minio container on local / standalone instances :
environment:
MINIO_ROOT_USER: ${STORAGE_ACCESS_KEY_ID}
MINIO_ROOT_PASSWORD: ${STORAGE_SECRET_ACCESS_KEY}
MINIO_BROWSER_REDIRECT_URL: http://${QFIELDCLOUD_HOST}:${MINIO_BROWSER_PORT}
Should the environment key of the minio service be changed in the docker-compose.override.standalone.yml to make use of this new STORAGE variable ?
There was a problem hiding this comment.
Yes, I need to address these.
gounux
reviewed
Jan 17, 2025
suricactus
force-pushed
the
QF-2760-files
branch
from
59dba4d to
a31eaa0
Compare
|
@gounux apologies for the force push, I first rebased and then realized I had to force push. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new enhanced way to store filedata. Before just dumped everything to the Object Storage. This made everything clumsy, slow and not flexible.
The plan is to quickly migrate all projects to the new storage and delete the legacy approach.
I have closed #1065, which was the same PR.