Simplify if() conditions on check result variables to fix CMP0054 warnin... #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ning
Remove use of an old hack that takes advantage of the auto-dereference
behavior of the if() command to detect if a variable is defined. The
hack has the form:
if("${VAR} MATCHES "^${VAR}$")
where "${VAR}" is a macro argument reference. Use if(NOT DEFINED) instead.
This also avoids warnings for CMake Policy CMP0054.
lassoan
pushed a commit
to lassoan/OpenIGTLink
that referenced
this pull request
May 3, 2017
EHN: This merge fix the ISSUE openigtlink#62 , also fix a potential bug in vtkIGTLToMRMLImage.
leochan2009
force-pushed
the
master
branch
5 times, most recently
from
fd79c15 to
3ec54f7
Compare
leochan2009
force-pushed
the
master
branch
5 times, most recently
from
4162c0a to
244276a
Compare
leochan2009
force-pushed
the
master
branch
2 times, most recently
from
d2e96e3 to
e04f1f1
Compare
leochan2009
force-pushed
the
master
branch
2 times, most recently
from
0e91008 to
269c68b
Compare
leochan2009
force-pushed
the
master
branch
2 times, most recently
from
5cacbce to
8ac5ca2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...g
Remove use of an old hack that takes advantage of the auto-dereference
behavior of the if() command to detect if a variable is defined. The
hack has the form:
if("${VAR} MATCHES "^${VAR}$")
where "${VAR}" is a macro argument reference. Use if(NOT DEFINED) instead.
This also avoids warnings for CMake Policy CMP0054.