Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add faker as a dependency #276

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

weilu
Copy link
Contributor

@weilu weilu commented Jul 23, 2024

It is used by individual module’s command script

Related PR: openimis/openimis-be-individual_py#114

It is used by individual module’s command script

Related PR: openimis/openimis-be-individual_py#114
@delcroip
Copy link
Member

Not sure we need to add it to all instances, I though we had a requirement-dev.txt for this ; @dragos-dobre @dborowiecki

Copy link

gitguardian bot commented Dec 4, 2024

⚠️ GitGuardian has uncovered 9 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
3700481 Triggered Django Secret Key 6db0693 openIMIS/openIMIS/settings.py View secret
3700481 Triggered Django Secret Key 6db0693 openIMIS/openIMIS/settings/security.py View secret
14324252 Triggered Generic Password 6db0693 .github/workflows/ci_assembly.yml View secret
14324252 Triggered Generic Password 6db0693 .github/workflows/ci_module.yml View secret
14324252 Triggered Generic Password 6db0693 .github/workflows/ci_module.yml View secret
14324252 Triggered Generic Password 6db0693 .github/workflows/ci_module.yml View secret
14324252 Triggered Generic Password 6db0693 .github/workflows/ci_assembly.yml View secret
14324252 Triggered Generic Password 6db0693 .github/workflows/ci_module.yml View secret
14324252 Triggered Generic Password 6db0693 .env.example View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@sniedzielski
Copy link
Contributor

The first usage of 'faker' was here https://github.com/openimis/openimis-be-insuree_py/blob/develop/insuree/management/commands/generateinsurees.py. There is no information about that library in https://github.com/openimis/openimis-be-insuree_py/blob/develop/setup.py and also on assembly backend. @weilu is right in that PR that we need to add to assembly too in my opinion hence my approval.

@delcroip
Copy link
Member

delcroip commented Jan 8, 2025

@sniedzielski both usage sugest a dev setup, so I would rather have requirements-dev.txt and add fake there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants