-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add faker as a dependency #276
base: develop
Are you sure you want to change the base?
Conversation
It is used by individual module’s command script Related PR: openimis/openimis-be-individual_py#114
Not sure we need to add it to all instances, I though we had a requirement-dev.txt for this ; @dragos-dobre @dborowiecki |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
3700481 | Triggered | Django Secret Key | 6db0693 | openIMIS/openIMIS/settings.py | View secret |
3700481 | Triggered | Django Secret Key | 6db0693 | openIMIS/openIMIS/settings/security.py | View secret |
14324252 | Triggered | Generic Password | 6db0693 | .github/workflows/ci_assembly.yml | View secret |
14324252 | Triggered | Generic Password | 6db0693 | .github/workflows/ci_module.yml | View secret |
14324252 | Triggered | Generic Password | 6db0693 | .github/workflows/ci_module.yml | View secret |
14324252 | Triggered | Generic Password | 6db0693 | .github/workflows/ci_module.yml | View secret |
14324252 | Triggered | Generic Password | 6db0693 | .github/workflows/ci_assembly.yml | View secret |
14324252 | Triggered | Generic Password | 6db0693 | .github/workflows/ci_module.yml | View secret |
14324252 | Triggered | Generic Password | 6db0693 | .env.example | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
The first usage of 'faker' was here https://github.com/openimis/openimis-be-insuree_py/blob/develop/insuree/management/commands/generateinsurees.py. There is no information about that library in https://github.com/openimis/openimis-be-insuree_py/blob/develop/setup.py and also on assembly backend. @weilu is right in that PR that we need to add to assembly too in my opinion hence my approval. |
@sniedzielski both usage sugest a dev setup, so I would rather have requirements-dev.txt and add fake there |
It is used by individual module’s command script
Related PR: openimis/openimis-be-individual_py#114