Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scGPT fine tuned #3

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Conversation

sainirmayi
Copy link
Contributor

@sainirmayi sainirmayi commented Dec 12, 2024

Describe your changes

A fine-tuned version of scGPT

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

Copy link
Contributor

@lazappi lazappi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some minor comments/questions but I think this looks pretty good.

src/methods/scgpt_fine_tuned/config.vsh.yaml Outdated Show resolved Hide resolved
src/methods/scgpt_fine_tuned/script.py Outdated Show resolved Hide resolved
src/methods/scgpt_fine_tuned/script.py Outdated Show resolved Hide resolved
src/methods/scgpt_fine_tuned/script.py Outdated Show resolved Hide resolved
src/workflows/run_benchmark/main.nf Outdated Show resolved Hide resolved
@sainirmayi sainirmayi requested a review from lazappi December 19, 2024 10:33
src/methods/scgpt_fine_tuned/script.py Outdated Show resolved Hide resolved
src/methods/scgpt_fine_tuned/script.py Outdated Show resolved Hide resolved
src/methods/scgpt_fine_tuned/script.py Outdated Show resolved Hide resolved
src/methods/scgpt_fine_tuned/script.py Outdated Show resolved Hide resolved
src/methods/scgpt_fine_tuned/functions.py Show resolved Hide resolved
@sainirmayi sainirmayi requested a review from lazappi December 20, 2024 08:55
Copy link
Contributor

@lazappi lazappi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, apart from the conflicts with main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants