Disable legacy tmpdir fixture

And fix two tests that used it.

pyproject.toml

@@ -64,7 +64,7 @@ add_ignore = [
 ]
 
 [tool.pytest.ini_options]
-addopts = "--tb=native --strict-markers --dist=loadgroup"
+addopts = "--tb=native --strict-markers --dist=loadgroup -p no:legacypath"
 testpaths = ["tests"]
 filterwarnings = [
     # ignnore dbapi() deprecation warnings for the third party TrinoDialect that we subclass

tests/functional/test_dump_example_data.py

@@ -1,8 +1,8 @@
 import contextlib
 
 
-def test_dump_example_data(call_cli, tmpdir):
-    with contextlib.chdir(tmpdir):
+def test_dump_example_data(call_cli, tmp_path):
+    with contextlib.chdir(tmp_path):
         call_cli("dump-example-data")
-    filenames = [path.basename for path in (tmpdir / "example-data").listdir()]
+    filenames = [path.name for path in (tmp_path / "example-data").iterdir()]
     assert "patients.csv" in filenames

tests/functional/test_graph_query.py

@@ -11,8 +11,8 @@
     shutil.which("dot") is None,
     reason="Graphing requires Graphviz library",
 )
-def test_graph_query(call_cli, tmpdir):  # pragma: no cover
-    output_file = tmpdir / "query.svg"
+def test_graph_query(call_cli, tmp_path):  # pragma: no cover
+    output_file = tmp_path / "query.svg"
     call_cli(
         "graph-query",
         FIXTURES_PATH / "dataset_definition.py",