Revert buggy in-memory engine change #2256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 62b1bae. The current behaviour is incorrect and, while theoretically fixable, is not easily fixable and so we revert it for now.
This was originally discovered by Hypothesis, although the example required shrinking by hand.
inglesp
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the changes in #2247 which caused the in-memory engine to give incorrect results. As the in-memory engine is used for dummy data generation I don't think we can afford to live with this.
Fixing this would involve having some mechanism whereby a PatientFrame derived from an EventFrame by picking rows can distinguish patient_ids which are actually present in the frame from those which exist just in order to give less confusing results in the sandbox/debug context.
The bug was originally discovered by the overnight generative tests (thanks Hypothesis!).
Slack discussion:
https://bennettoxford.slack.com/archives/C069YDR4NCA/p1732729097689479