Allow measures to specify dummy data additional population constraint #2328
Conversation
rebkwok
force-pushed
the
additional-pop-constraints-measures
branch
from
8d02182 to
8fb066d
Compare
Deploying databuilder-docs with
|
| Latest commit: |
8bf2037
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dace3739.databuilder.pages.dev |
| Branch Preview URL: | https://additional-pop-constraints-m.databuilder.pages.dev |
rebkwok
force-pushed
the
additional-pop-constraints-measures
branch
from
90e2baf to
3059f5a
Compare
ehrql/query_language.py
Outdated
| else: | ||
| self.additional_population_constraint = None |
There was a problem hiding this comment.
do we need this branch? (the other branch tested for is not None, rather than e.g. for truthy)
There was a problem hiding this comment.
Well, I just blindly copied it from where it was before, but I think you're right, it'll always be None already here
ehrql/query_language.py
Outdated
| self.additional_population_constraint = ( | ||
| self.additional_population_constraint._qm_node | ||
| ) |
There was a problem hiding this comment.
I don't think this is quite right because now the "validate" method is changing the value of self.additional_population_constraint. So, for example, it will fail if you call it twice in a row.
I think you want to make it a set_additional_population_constraint() method which takes the value, validates it, and then updates the attribute if it's valid.
There was a problem hiding this comment.
Huh that's how I did it first. Will change it back, hadn't considered calling it twice
So it can be shared by dataset and measures dummy data
rebkwok
force-pushed
the
additional-pop-constraints-measures
branch
from
3059f5a to
8bf2037
Compare
No description provided.