Disable the download-with-vmp button if a dm+d codelist is undownloadable #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able By undownloadable, we mean that it doesn't have an identifiable code column header in the csv_data field, so it's undownloadable for OSI, and also can't be used to retrieve mapped VMPs. We now validate codelists created by csv upload, so this only applies to particularly old codelists. These can still be downloaded in their original format. e.g. https://opencodelists.org/codelist/opensafely/methotrexate-oral/738b5e12/#full-list contains codes in a "VMP" column, which is not one of the allowed code headers.
Since "full list" for a dm+d codelist may not be the full full list including mapped VMPs that will be used in an OpenSAFELY project.
evansd
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By undownloadable, we mean that it doesn't have an identifiable code
column header in the csv_data field, so it's undownloadable for OSI, and
also can't be used to retrieve mapped VMPs. We now validate codelists created
by csv upload, so this only applies to particularly old codelists. These
can still be downloaded in their original format.
e.g. https://opencodelists.org/codelist/opensafely/methotrexate-oral/738b5e12/#full-list
contains codes in a "VMP" column, which is not one of the allowed code headers.
This will prevent users hitting the assertion error e.g.:
https://ebm-datalab.sentry.io/issues/4628776626/?alert_rule_id=1877862&alert_type=issue¬ification_uuid=788df5b5-7b73-4483-b635-ebc0cab896a6&project=5248013&referrer=slack
Also adds a footnote on the "full list" tab, as suggested by @chrisjwood16, since "full list" for a dm+d codelist may not be the full full list including mapped VMPs that will be used in an OpenSAFELY project.