Some additional fixes for CSV downloads #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some additional fixes for CSV downloads:
The cached CSV data was previously only being saved when codelist shas were checked, not when the csv file was downloaded. This was irrelevant for dm+d downloads, because the weekly import re-cached everything, but it meant that other downloads were never using the cache when we expected them to.
Fixes a bug with creating the formatted CSV download with mapped-in VMPs where the original CSV data did not contain an identifiable "term" column (this affected a total of 12 codelist versions)