-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Update to Django 5.1 #2264
Draft
StevenMaude
wants to merge
17
commits into
main
Choose a base branch
from
steve/django-5.1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue here is with coding systems test failures, due to the way the tests use databases. |
This also needs local testing as previously to ensure everything is OK with the upgrade. |
StevenMaude
added
the
deck-scrubbing
Tech debt or other between-initiative tidy-up work
label
Dec 18, 2024
StevenMaude
force-pushed
the
steve/django-5.1
branch
from
January 7, 2025 16:15
0c3126d
to
bc9c47c
Compare
This changes `CheckConstraint.check` to `CheckConstraint.condition`. See also opensafely-core/job-server@190a645
This results in a warning if not enabled, but will be the default behaviour in Django 6. Therefore, enable the setting and suppress the deprecation warning resulting from having that setting enabled (which will be removed in Django 6). See https://adamj.eu/tech/2023/12/07/django-fix-urlfield-assume-scheme-warnings/
Review this commit.
There's a global here that's messier, and we could tidy.
There's lots of adding fixtures to the tests, that could be tidier.
Check which fixtures are used here.
StevenMaude
force-pushed
the
steve/django-5.1
branch
from
January 16, 2025 23:20
0f0c70b
to
2629fc7
Compare
Current status of this:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2115.
This PR is to: