-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dataset failure distribution list #99
Update dataset failure distribution list #99
Conversation
eaeed10
to
951750f
Compare
Without it, several GitHub actions will fail unexpectedly.
The distribution list contains the @NAMEs of users who should be notified on dataset failure. With @LiamHart-hub's agreement, we will remove Jongmassey.
The distribution list contains the @NAMEs of users who should be notified on dataset failure. With @LiamHart-hub's agreement, we will add JulietUnderdown1.
951750f
to
070499a
Compare
The distribution list contains the @NAMEs of users who should be notified on dataset failure. inglesp was on the distribution list because he was data team lead. However, the data team no longer exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Could you explain a little more about codelists.json
and why those failures hadn't happened/caused problems before?
Also, IIRC there might be some deploy faff for this once merged.
The distribution list contains the @NAMEs of users who should be notified on dataset failure. With @JulietUnderdown1's agreement, we will add iaindillingham.
I'm afraid I didn't dig into why |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for explaining why each change was being made.
As mentioned earlier, I think we should review this new list of people in a few weeks and change it again if necessary.
The distribution list contains the @NAMEs of users who should be notified on dataset failure. With @LiamHart-hub's agreement, we will make the following changes: