Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dataset failure distribution list #99

Merged
merged 5 commits into from
Apr 3, 2024

Conversation

iaindillingham
Copy link
Member

@iaindillingham iaindillingham commented Apr 3, 2024

The distribution list contains the @NAMEs of users who should be notified on dataset failure. With @LiamHart-hub's agreement, we will make the following changes:

@iaindillingham iaindillingham force-pushed the iaindillingham/update-dataset-failure-users branch from eaeed10 to 951750f Compare April 3, 2024 10:31
Without it, several GitHub actions will fail unexpectedly.
The distribution list contains the @NAMEs of users who should be
notified on dataset failure. With @LiamHart-hub's agreement, we will
remove Jongmassey.
The distribution list contains the @NAMEs of users who should be
notified on dataset failure. With @LiamHart-hub's agreement, we will add
JulietUnderdown1.
@iaindillingham iaindillingham force-pushed the iaindillingham/update-dataset-failure-users branch from 951750f to 070499a Compare April 3, 2024 10:56
The distribution list contains the @NAMEs of users who should be
notified on dataset failure. inglesp was on the distribution list
because he was data team lead. However, the data team no longer exists.
Copy link
Contributor

@Jongmassey Jongmassey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Could you explain a little more about codelists.json and why those failures hadn't happened/caused problems before?

Also, IIRC there might be some deploy faff for this once merged.

The distribution list contains the @NAMEs of users who should be
notified on dataset failure. With @JulietUnderdown1's agreement, we will
add iaindillingham.
@iaindillingham
Copy link
Member Author

I'm afraid I didn't dig into why codelists.json is required now, but wasn't required when the repo was last pushed (2022-12-22). However, that's over a year ago and a lot has changed since then. You may be interested in opensafely/gh-testing-research#4, which caused some of the earlier failures.

Copy link

@lucyb lucyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for explaining why each change was being made.

As mentioned earlier, I think we should review this new list of people in a few weeks and change it again if necessary.

@iaindillingham iaindillingham merged commit dfd59ed into main Apr 3, 2024
8 checks passed
@iaindillingham iaindillingham deleted the iaindillingham/update-dataset-failure-users branch April 3, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants