Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Added ConfDataSet to the Services Wizard #1332

Merged
merged 8 commits into from
Nov 13, 2023
Merged

Chore: Added ConfDataSet to the Services Wizard #1332

merged 8 commits into from
Nov 13, 2023

Conversation

pascalwilbrink
Copy link
Member

@pascalwilbrink pascalwilbrink commented Oct 18, 2023 •
edited
Loading

Fixes #1227

@pascalwilbrink pascalwilbrink marked this pull request as ready for review October 18, 2023 15:01
@Sander3003
Copy link
Member

@JakobVogelsang can you review this?

JakobVogelsang
JakobVogelsang requested changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@JakobVogelsang JakobVogelsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some settings seem to not be acc to the issue description

packages/open-scd/src/wizards/service-log-settingsgroup.ts Outdated Show resolved Hide resolved
packages/open-scd/src/wizards/service-log-settingsgroup.ts Outdated Show resolved Hide resolved
packages/open-scd/src/wizards/service-log-settingsgroup.ts Outdated Show resolved Hide resolved
packages/open-scd/src/wizards/service-log-settingsgroup.ts Show resolved Hide resolved
packages/open-scd/test/integration/wizards/services-wizard.test.ts Show resolved Hide resolved
@JakobVogelsang JakobVogelsang self-requested a review November 2, 2023 08:17
JakobVogelsang
JakobVogelsang reviewed Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@JakobVogelsang JakobVogelsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

some JavaScript files seem not to belong to this PR

JakobVogelsang
JakobVogelsang approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@JakobVogelsang JakobVogelsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pascalwilbrink pascalwilbrink merged commit 2d602b2 into main Nov 13, 2023
4 checks passed
@pascalwilbrink pascalwilbrink deleted the Add_ConfDataSet_To_Services branch November 13, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakobVogelsang JakobVogelsang JakobVogelsang approved these changes

@danyill danyill Awaiting requested review from danyill

Assignees
No one assigned
Labels
None yet
Projects
PR Overview
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Services section missing item
3 participants
@pascalwilbrink @Sander3003 @JakobVogelsang